Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim auto_generated flag #950

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Dim auto_generated flag #950

merged 3 commits into from
Feb 16, 2022

Conversation

albertz
Copy link
Member

@albertz albertz commented Feb 15, 2022

Allows for better Dim is_equal which does not rely on the description.

#634

@albertz albertz requested a review from Zettelkasten February 15, 2022 23:23
@albertz
Dim auto_generated flag
3fa6739 
Allows for better Dim is_equal
which does not rely on the description.

#634
@albertz
Dim is_equal small fix
acf85fe
@albertz albertz force-pushed the albert-dim-tag-eq-no-desc branch from eb4fa70 to acf85fe Compare February 15, 2022 23:34
@Zettelkasten
Copy link
Member

Looks good!
I wonder about #865: here we could also say that same_spatial_matches only matches two spatial dims if at least one is auto generated. Or maybe more general even, that two user defined dims only match when their identities are the same.
That would break transitivity though (e.g. an auto generated dims matches two different user defined dims, which themselves would not match). Not sure what the impact of that would be. This would be something for another PR.

@albertz albertz merged commit 3650515 into master Feb 16, 2022
@albertz albertz deleted the albert-dim-tag-eq-no-desc branch February 16, 2022 08:21
albertz added a commit that referenced this pull request Feb 16, 2022
@albertz
Dim auto_generated flag (#950)
96fedc4 
Allows for better Dim is_equal
which does not rely on the description.

#634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettelkasten Zettelkasten Awaiting requested review from Zettelkasten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertz @Zettelkasten